Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Properly calculate vertex range when divisor is active #7820

Merged
merged 1 commit into from Mar 22, 2020
Merged

rsx: Properly calculate vertex range when divisor is active #7820

merged 1 commit into from Mar 22, 2020

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Mar 21, 2020

  • Tweaks attrib divisor optimization logic a bit. Fixes particle rendering in Rachet & Clank future fames which resulted in vertex explosion before.

@kd-11
rsx: Properly calculate vertex range when divisor is active
34321ef 
- The upper bound is to be rounded up, not down.
@MsDarkLow
Copy link
Contributor

MsDarkLow commented Mar 21, 2020 •
edited

Example of the particles being correctly rendered on the saw in R&C: ToD
Master
Master
PR (Please ignore the fps, that is due to pausing in the game)
PR

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Properly calculate vertex range when divisor is active rsx: Properly calculate vertex range when divisor is active Mar 22, 2020
@kd-11 kd-11 merged commit 12044bd into RPCS3:master Mar 22, 2020
@Cervoxx Cervoxx mentioned this pull request Mar 27, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kd-11 @MsDarkLow