Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_prx Improvements #7845

Merged
merged 3 commits into from Mar 25, 2020
Merged

sys_prx Improvements #7845

merged 3 commits into from Mar 25, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Mar 24, 2020

  • Implement sys_prx_get_module_list: Used by sys_prx_exitspawn_with_level to get list of modules and call sys_prx_stop_module for each module id, which (I think) is used by exitspawn functions and normal prcosess exit.
  • Add missing logic and error codes for sys_prx_start/stop/unload_module.

@sampletext32
Copy link
Contributor

sampletext32 commented Mar 24, 2020

Shouldn't you remove very first sys_prx.todo? Because function is somehow implemented, even not fully, but you add new todos that specify the work. @elad335

@elad335
Copy link
Contributor Author

elad335 commented Mar 24, 2020

The general use of the public "sys_prx_get_module_list" frunction from https://github.com/RPCS3/rpcs3/blob/master/rpcs3/Emu/Cell/Modules/sys_prx_.cpp#L199 is implemented here, but there more uses to the syscall which are not implemented here so the TODO is still needed.
Basically only bit 1 of "flags" arguments handling is implemented here, but the other bit is not.
@sampletext32

@elad335 elad335 force-pushed the sys-prx-list branch 2 times, most recently from 29bd649 to 5b7864a Compare March 24, 2020 10:15
@sampletext32
Copy link
Contributor

So, the "todo" should be more precise, not general. So if you cover one bit, todo should cover the other. It would help in future problems investigations. Correct me, if I am wrong.

@elad335
Copy link
Contributor Author

elad335 commented Mar 24, 2020

Ok, done. @sampletext32

@elad335 elad335 changed the title sys_prx: Implement sys_prx_get_module_list sys_prx Improvements Mar 24, 2020
@elad335 elad335 force-pushed the sys-prx-list branch 8 times, most recently from b936349 to c98bebf Compare March 24, 2020 15:42
* Add missing error codes, "internal" errors are ones which are not reachable from liblv2.sprx functions

* Implement SYS_PRX_NO_RESIDENT (unloading module) for _sys_prx_start_module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants