PPU LLVM: Add relocation 5 for ADDIS #7862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Mar 26, 2020
•
elad335
commented
- Add more u16 relocations (4, 5, 6) support for instructions which already supported atleast one of them including ADDIS as mentioned in PPU LLVM: Unsupported relocation 5 #7855.
- More strict infinite desync detection,
- Fix sys_prx_start/stop_module in liblv2.sprx HLE, add missing result reset.
AniLeo
reviewed
Mar 26, 2020
+ Add some more for u16 relocations (4, 5, 6), simplify logic.
6 desyncs per second for 1.5 seconds is pretty bad already.
|
I can see a lot of duplicating checks. Maybe they are worth extracting into a func? |
Not really, not in this case. This is also "old style" internal API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.