Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make log silencing dynamic #7893

Merged
merged 6 commits into from Mar 31, 2020
Merged

Try to make log silencing dynamic #7893

merged 6 commits into from Mar 31, 2020

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Mar 28, 2020

Log:

It is possible to change log levels for all the log channels by editing the config file.
Previously, the log levels were applied whenever a config file was decoded.
This meant that we updated the log channels whenever any config file, either global or custom, was read. Apart from being suboptimal in the first place, this also meant that changing the "Silence All Logs" option was ignored whenever a config was changed.
So what did I do to improve the situation?

  • The channel map will only be applied to the log channels when we actually apply a config
  • Custom configs do not override the global setting anymore and vice-versa

TODO:

Figure out a better way to apply the interaction between silencing and changing levels:

  • At rpcs3 boot ?
  • Can custom configs also non-cell-channels, like GUI or others?

Misc changes:

  • Added some recent missing files to the visual studio project
  • Changed sig_log to SIG
  • Changed log level of some keyvault message to trace to stop spam when opening the settings dialog
  • Added cacert.pem to gitignore, because I have it in my working directory for testing

@Nekotekina
Copy link
Member

Well, the only change that left me confused was "Changed sig_log to SIG"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants