Try to make log silencing dynamic #7893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log:
It is possible to change log levels for all the log channels by editing the config file.
Previously, the log levels were applied whenever a config file was decoded.
This meant that we updated the log channels whenever any config file, either global or custom, was read. Apart from being suboptimal in the first place, this also meant that changing the "Silence All Logs" option was ignored whenever a config was changed.
So what did I do to improve the situation?
TODO:
Figure out a better way to apply the interaction between silencing and changing levels:
Misc changes: