Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellSearch: Change search state before invoking callbacks #7951

Merged
merged 1 commit into from Apr 5, 2020

Conversation

CookiePLMonster
Copy link
Contributor

It makes sense to change cellSearch state before invoking an user callback, since it acts as a broadcast for state change. WipEout HD uses those callbacks to start a new search, which would errorerously fail due to cellSearch still being "busy".

This "fixes" WipEout HD's searches failing - since it relies on yet unimplemented playlists, custom songs still don't work but now the game thinks search has succeeded and found 0 entries (instead of failing).

@Nekotekina Nekotekina merged commit fd09dde into RPCS3:master Apr 5, 2020
@CookiePLMonster CookiePLMonster deleted the cellsearch-ordering branch April 5, 2020 13:41
@Tom-Neverwinter
Copy link

Thank you!!!

@Augusto7743
Copy link

rpcs3-v0.0.9-10120
WipEout HD Demo using :

  • LLVM first start crash before begin the race and second start crash rpcs3 when loading the game.
  • ASMJIT game run normally using SPU Safe and not need configure driver wake up delay to 250 us.
    Gameplay not totally tested because the slow gameplay speed.

@CookiePLMonster
Copy link
Contributor Author

CookiePLMonster commented Apr 7, 2020

I tested on latest and was able to get to the race without any issues.

https://cdn.discordapp.com/attachments/442667232489897997/696983979630526465/unknown.png

Your issues are not related to this PR, especially given that cellSearch only runs on startup and not when you are entering the race (I think).

EDIT:
One important note is that I did not update my game - it's still on 01.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants