Translation fixes #7965
Merged
Translation fixes #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSuih
reviewed
Apr 6, 2020
rpcs3/rpcs3qt/emu_settings.cpp
Outdated
| case emu_settings::Renderer: | ||
| switch (static_cast<video_renderer>(index)) | ||
| { | ||
| case video_renderer::null: return tr("Null"); |
There was a problem hiding this comment.
There is already logic somewhere that converts "Null" to "Disable video output", can't it be merged into this function? Same goes for the other tr("Null")'s in this switch.
There was a problem hiding this comment.
I removed the useless string replacements.
There was a problem hiding this comment.
Any chance of naming the keyboard, microphone etc. null handlers to Disconnected (or something more fitting)? It's bit out of scope for this PR but it'd be more consistent and would save translations from trouble of coming up with a translation for the word Null.
Megamouse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.