sys_rsx: Minor atomicity fixes #7978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Apr 7, 2020
•
elad335
commented
- Write FIFO get+put atomically in FIFO start command.
- Reset and set flip flip flags atomically, the gcm methods neither use a lock so it's a expected that sys_rsx will handle synchronization.
- Always wait for sys_rsx events to be sent, EBUSY is not a success error code! (EBUSY means the event queue is full by the time of sending the event)
- Optimize vblank events by squashing it into one event instead of two.
- Send events only if they are masked by gcm.
elad335
force-pushed
the
vm-test
branch
7 times, most recently
from
1c12828
to
fb0d20a
Compare
In realhw the events are only sent if they are masked in driver_info->handlers as well.
kd-11
reviewed
Apr 7, 2020
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Apr 8, 2020
kd-11
pushed a commit
that referenced
this pull request
Apr 8, 2020
fengjixuchui
added a commit
to fengjixuchui/rpcs3
that referenced
this pull request
Apr 8, 2020
sys_rsx: Fixup after RPCS3#7978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.