Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show state of Accurate LLVM DFMA option in GUI for CPUs that support FMA #8001

Merged
merged 1 commit into from Apr 11, 2020
Merged

Show state of Accurate LLVM DFMA option in GUI for CPUs that support FMA #8001

merged 1 commit into from Apr 11, 2020

Conversation

RainbowCookie32
Copy link
Contributor

Follow-up to #7981

If you had a CPU with FMA support, the option was greyed out and it was showed as unchecked. This PR aims to fix that. It also tweaks the tooltip for the option a bit to reflect that you can't disable it if your CPU has FMA support, and simplifies the code.

Master:
Before

This PR:
After

Waiting for my Amazing Contribution label, tyvm

@Yahfz
Copy link
Contributor

Yahfz commented Apr 9, 2020

Performance is better if the cpu supports fma, so maybe try to include that first? It prevents users from trying to disable it in the config file even on cpus that support it.

@RainbowCookie32
Copy link
Contributor Author

Maybe changing it to

Provides extra accuracy on FMA instructions at the cost of performance in CPUs that don't support it.
While disabling it might give a decent performance boost, it may also introduce subtle bugs that otherwise do not occur.
You can't disable it if your CPU supports FMA.

I'm open to suggestions

@illusion0001
Copy link
Contributor

Thanks 😻

rpcs3/rpcs3qt/tooltips.h Outdated Show resolved Hide resolved
@RainbowCookie32 RainbowCookie32 changed the title Show state of Acurate LLVM DFMA option in GUI for CPUs that support FMA Show state of Accurate LLVM DFMA option in GUI for CPUs that support FMA Apr 10, 2020
@vsub
Copy link

vsub commented Apr 11, 2020

@RainbowCookie32

Provides extra accuracy on FMA instructions at the cost of performance in CPUs that don't support it.
While disabling it might give a decent performance boost, it may also introduce subtle bugs that otherwise do not occur.
You can't disable it if your CPU supports FMA.

I prefer the old description.
This one made me think,I may get some decent performance boost even if my cpu support it by disabling it and most users first care about speed than accuracy

They both say the same thing but while reading a new sentence without paying much attention,you may ignore what the last one was saying,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants