sys_rsx: Implement cellGcmSysGetLastVBlankTime, add some error checks #8004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Apr 10, 2020
•
elad335
commented
- Implement LLE cellGcmSysGetLastVBlankTime.
- Check zcull/tiles offset if bigger than memory limits of MAIN/LOCAL memory.
- Check memory mapping of offset if location is MAIN.
- Check pitch/size for 0 as coming from hw tests.
- In addition: fix 'bound' check of tiles, seem to rely on the bits location is in. (0 means not bound, anything else is bound)
- Add locks for zcull/tiles/displaybuffer binding.
- Fix vblank thread stop regression from sys_rsx: Minor atomicity fixes #7978, add missing emulation state check in EBUSY wait loop.
- Fix get_optimal_blit_target_properties for local memory.
- Write FIFO ref+get atomically.
- Warn if RSX is not idle during crucial points.
|
Is binded a real word? |
elad335
force-pushed
the
zcull-tiles
branch
2 times, most recently
from
c7d1d1f
to
386f463
Compare
|
Therefore super important urgent commit elad335@d487b4d. |
elad335
force-pushed
the
zcull-tiles
branch
3 times, most recently
from
020dc86
to
74ff434
Compare
kd-11
reviewed
Apr 11, 2020
kd-11
reviewed
Apr 11, 2020
kd-11
reviewed
Apr 11, 2020
* Check zcull/tiles offset if bigger than max MAIN/LOCAL size. * Check memory mapping of offset if location is MAIN. * Check pitch/size for 0 as coming from hw tests. * In addition: fix 'bound' check of tiles, seem to rely on the bits location is in. * Add locks for zcull/tiles/displaybuffer binding.
May contribute to better FIFO synchronization in some cases.
kd-11
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.