Experimental code for shared memory reservations #8008
Conversation
rpcs3/Emu/Memory/vm.cpp
Outdated
| { | ||
| static const auto test_addr = [](const u32 target, const u32 addr, const u32 end) | ||
| if (addr < 0x10000 + g_locations[vm::main]->size || addr >= 0xc0000000) |
There was a problem hiding this comment.
stack memory allows reservations.
There was a problem hiding this comment.
Well, I didn't assume otherwise. I only assumed it didn't allow oddities (shared memory).
|
Didn't see any regressions in heavy games from my testing like GOW, Wipeout, MS Apocalypse. GOW3 PR: Master: |
|
Try with tsx disabled. |
|
Tried some games on NFS ProStreetWith PR: Portal 2With PR: Without PR: |
Nekotekina
force-pushed
the
rsrv
branch
2 times, most recently
from
b85c88b
to
908b0e4
Compare
This comment has been minimized.
This comment has been minimized.
|
You need to download artifact from https://github.com/RPCS3/rpcs3/pull/8008/checks?check_run_id=582584162 - go to azure pipelines. |
|
With Ni no Kuni there doesn't seem to be any real difference (frames are not capped and same value is pure coincidence) PR MASTER |
|
Fixed a bug, need retest. |
|
Tested with Persona 5 and Nier on my i7 7700HQ and to my absolute surprise, I saw no perf degradation. LGTM. |
|
tested on resistance 1/3 no difference |
|
No difference for me too, i think. NFS ProStreetwith PR: master: |
|
Heavenly Sword seems to have the same performance as well |
|
Tested it as well on my Intel 4770HQ laptop with Ni no kuni. The FPS is ranging from 15-26 on this build and same with master build. |
Nekotekina
changed the title
Nekotekina
force-pushed
the
rsrv
branch
3 times, most recently
from
03664ab
to
8b17fd2
Compare
Enables trivial synchronization between shared mem. Reduces memory usage, but potentially degrades performance. Rename an overload of vm::passive_lock to vm::range_lock.
Optimization.
If there is no noticeable degradation, I may consider using it. Currently it's very unclear.
Both TSX and non-TSX CPUs are welcomed to test.