[Code enhancements] Fix various explicitness, laziness, hard codes #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampletext32
changed the title
elad335
requested changes
Apr 11, 2020
|
Doesn't seem like a good idea to use isdigit, because of its pitfalls (UB if outside of unsigned char range). |
elad335
reviewed
Apr 11, 2020
This is done mostly for readability reasons. And btw, it works with std::string[indexed] value which are only basic chars. So it doesn't seem like UB for me. |
elad335
reviewed
Apr 11, 2020
elad335
approved these changes
Apr 11, 2020
|
Offtop. |
|
You may want to squash some commits |
Megamouse
reviewed
Apr 12, 2020
Megamouse
reviewed
Apr 12, 2020
Done |
Megamouse
reviewed
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes numerous code confusions.
Fixes #7997