cellAudio: implement downmix to 5.1 and make most audio settings dynamic #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
changed the title
|
Updated PR to make more audio settings dynamic (see original PR description). |
arabek
reviewed
Jun 20, 2020
I could not properly reset the audio backend and call CreateMasteringVoice without getting errors
The setting does not actually define the channels themselves, only the downmix option that the PS3 provides. Channels might be changed seperately in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might currently not work on linux audio backends, but xaudio and openal seemed fine.
Let me know if this works or if I missed something.