Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPU/PPU LLVM: Fix cpu_translator::get_const_vector<v128>() #8652

Merged
merged 3 commits into from Jul 30, 2020
Merged

SPU/PPU LLVM: Fix cpu_translator::get_const_vector<v128>() #8652

merged 3 commits into from Jul 30, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jul 29, 2020 •
edited

  • Add support for 128-bit integers, construct it using the base llvm::APInt.
  • Fix the use of llvm::ConstantExpr, we cannot evaluate it as constant data!

Those bugs existed before but they were too rare to be noticed until #8559.
Fixes #8651

@elad335 elad335 force-pushed the i128 branch 3 times, most recently from edd71ec to eb4b4b8 Compare July 29, 2020 18:28
@Nekotekina
Copy link
Member

I prefer eliminating the cause of ConstantExpr instead of losing optimization because of it (and it can be pretty horrible).

@elad335
Copy link
Contributor Author

elad335 commented Jul 29, 2020

Bitcast, on it.

@elad335 elad335 force-pushed the i128 branch 2 times, most recently from 902af15 to a96a78a Compare July 29, 2020 20:20
@elad335
Copy link
Contributor Author

elad335 commented Jul 29, 2020

Foxed.

@Nekotekina
Copy link
Member

cpu_translator::bitcast already exists, not sure why you re-added it

@elad335
Copy link
Contributor Author

elad335 commented Jul 29, 2020 •
edited

cpu_translator::bitcast already exists, not sure why you re-added it

Fixed.

@AniLeo AniLeo merged commit dd49762 into RPCS3:master Jul 30, 2020
@elad335 elad335 deleted the i128 branch July 30, 2020 19:07
@illusion0001 illusion0001 mentioned this pull request Aug 5, 2020
Closed
@VeroxinFox VeroxinFox mentioned this pull request Aug 5, 2020
Closed
@dio-gh dio-gh mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix CPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PPU LLVM compilation crashes for some games after #8559
3 participants
@elad335 @Nekotekina @AniLeo