Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Unify composite texture creation and management #8710

Merged
merged 1 commit into from Aug 10, 2020

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Aug 9, 2020

  • Some texture accesses require image compositing steps to assemble the requested image from existing subresources. Handle all the common routines in a unified manner to avoid having one broken path (e.g mipmap gather not supporting bitcast operations)

Fixes #8229

- Some texture accesses require image compositing steps to assemble the requested image from existing subresources.
  Handle all the common routines in a unified manner to avoid having one broken path (e.g mipmap gather not supporting bitcast operations)
@Xcedf
Copy link

Xcedf commented Aug 9, 2020

Confirm it fixes the issue, but only for native res
image
Upscaled resolutions have some green overlay, similar to Naughty Dog MLAA when upscaled, looks like it's different issue
image

@kd-11
Copy link
Contributor Author

kd-11 commented Aug 9, 2020

Upscaling 'green' is because you cannot interpolate floats byte-wise so the result after scaling when bitcast to float becomes nonsense. You should be able to fix it using resolution scaling threshold normally, unless the pass generating the data is full-frame in which case there isn't anything we can do about it.

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Unify composite texture creation and management rsx: Unify composite texture creation and management Aug 10, 2020
@kd-11 kd-11 merged commit 6850533 into RPCS3:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baja edge of control |BLES00359] serious graphical glitch
2 participants