improve cellHddGameCheck

[Megamouse]

No description provided.

[elad335]

Thats a huge copy paste of cellGameDataCheckCreate2, just use a shared function.

[Megamouse]

maybe seems like it but not really. it has both different enum values/log messages as well as different datatypes / HG check / sound format and resolution

[elad335]

[elad335]

logging - use ppu.current_function for logging then and not the original name of the function.

[Megamouse]

the strings will vary either way.
Idk what it looks like on real PS3, But one message would be:
The game data was not found!
while the other would be:
The hdd boot game was not found!

[Megamouse]

and since i have another PR open that adds translations we'll have to use different enums values
.

[jy95]

@Megamouse little question : does your PR fixes this strange bug on POP 2008 ? https://forums.rpcs3.net/thread-196966.html

[Megamouse]

Try installing update 01.01 for that game. It will create the required folder. It shouldn't be related to this PR I think

[elad335]

This function is called cellHddGameCheck, not cellHddGameCheckCreate. At best it only updates PARAM.SFO parameters with strict error checking for it.

[elad335]

I do not think games are allowed to create HG game data, only GD.

[elad335]

Maybe remove this assert, if non HG content is accessed ERROR_BROKEN should be returned.

[Megamouse]

This function can also create new directories, so I don't see the relevance of HG content in this topic.