New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: Add PPU threads to debug tab [Experimental] #9018
Conversation
8514394
to
a098e1f
Compare
Why do we need it on debug tab? Regardless of big red warning, it will be used in the most stupid way... |
rpcs3/rpcs3qt/settings_dialog.ui
Outdated
<property name="title"> | ||
<string>PPU Threads Count</string> | ||
</property> | ||
<layout class="QVBoxLayout" name="gb_num_ppu_threads"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong name
rpcs3/rpcs3qt/settings_dialog.ui
Outdated
<item> | ||
<widget class="QGroupBox" name="gb_num_ppu_threads"> | ||
<property name="title"> | ||
<string>PPU Threads Count</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string>PPU Threads Count</string> | |
<string>PPU Thread Count</string> |
Fixed conflicts, if it's a convenient feature for someone, okay then. |
My 2 cents. Logically debug tab should be used for 2 things only:
There should some checkbox etc.. to even show this settings with info, that is for points above.. Normal users shouldnt use (be forced to use these to make games running) these at all. |
The Some features also exist in this weird limbo between being extremely niche, and being useful in those niche cases even for regular users. Such options include: In any case, I don't think this discussion is best to be had under this PR (it's more Discord territory). The PR is already merged, and there's nothing wrong with it fundamentally. Just exposes one of the many niche PPU options, that used to be config-file-only before. |
I've put warnings for dumb users to not mess with this setting as well.