Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Add PPU threads to debug tab [Experimental] #9018

Merged
merged 1 commit into from Jun 20, 2021

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Oct 2, 2020

I've put warnings for dumb users to not mess with this setting as well.

@elad335 elad335 force-pushed the ppu-setting branch 2 times, most recently from 8514394 to a098e1f Compare October 2, 2020 16:27
@Nekotekina
Copy link
Member

Why do we need it on debug tab? Regardless of big red warning, it will be used in the most stupid way...

@elad335 elad335 closed this Oct 4, 2020
@elad335 elad335 changed the title GUI: Add PPU threads to debug tab GUI: Add PPU threads to debug tab [Experimental] Nov 13, 2020
@elad335 elad335 reopened this Nov 13, 2020
<property name="title">
<string>PPU Threads Count</string>
</property>
<layout class="QVBoxLayout" name="gb_num_ppu_threads">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong name

<item>
<widget class="QGroupBox" name="gb_num_ppu_threads">
<property name="title">
<string>PPU Threads Count</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string>PPU Threads Count</string>
<string>PPU Thread Count</string>

@Megamouse Megamouse added the GUI label Nov 13, 2020
@Nekotekina
Copy link
Member

Fixed conflicts, if it's a convenient feature for someone, okay then.

@Nekotekina Nekotekina merged commit 40493c5 into RPCS3:master Jun 20, 2021
@ruthan
Copy link

ruthan commented Jun 21, 2021

My 2 cents. Logically debug tab should be used for 2 things only:

  1. Developers only whatever they want to use add..
  2. For users getting more information to help developers.. and for testing of special features which not fully integrated.

There should some checkbox etc.. to even show this settings with info, that is for points above.. Normal users shouldnt use (be forced to use these to make games running) these at all.

@dio-gh
Copy link
Contributor

dio-gh commented Jun 21, 2021

The Debug tab is already meant to be used that way; you need to edit an .ini file manually to even enable the tab in the first place. But this doesn't mean people will actually heed to these guidelines. You can lay down rules all you want, as long as people can find a way to violate them, they will. Especially if they get comfy youtube tutorials on the side, instructing them to do so.

Some features also exist in this weird limbo between being extremely niche, and being useful in those niche cases even for regular users. Such options include: CPU Blit, High Precision Z, Accurate GETLLAR, and then some. One could argue that these should be moved to the Advanced tab then - I made that argument before myself while I still had staff channel access, but these are ultimately indeed very sparingly useful. At that point, it becomes a UI/UX design question, since you can't just keep bloating user-facing tabs without end.

In any case, I don't think this discussion is best to be had under this PR (it's more Discord territory). The PR is already merged, and there's nothing wrong with it fundamentally. Just exposes one of the many niche PPU options, that used to be config-file-only before.

@elad335 elad335 deleted the ppu-setting branch September 19, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants