Virtual memory minor refactoring #9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
fixup
branch
3 times, most recently
from
0e32dbe
to
b0a7039
Compare
Nekotekina
changed the title
elad335
reviewed
Nov 8, 2020
elad335
reviewed
Nov 8, 2020
elad335
reviewed
Nov 8, 2020
elad335
approved these changes
Nov 8, 2020
Move bits to the highest, set RWX order. Use only one reserved value (W = locked). Assume lock size 128 for range_locked. Add new "Size" template argument that replaces normal argument.
Add complementary unmap_self() method. Move VirtualMemory to util/vm.hpp Minor associated include cleanup. Move asm.h to util/asm.hpp
Renamed from g_shareable. Contains pointers instead of bits. Used in range locks to prevent any "collision" between memory.
Use optimistic locking and optimistic loop (expecting 1 iteration).
Use some prefetching Use optimistic locking
Also to sys_semaphore_create, although we don't do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsx_cache, oh my...
But could be worse.