Minor (not really) update to waitable atomics API #9244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
fixup
branch
2 times, most recently
from
6622e27
to
8af1c9d
Compare
Instead of plain waiting while equal to some value, it can be something like less, or greater, or even bitcount. But it's a draft and untested. Hopefully doesn't break anything.
Nekotekina
force-pushed
the
fixup
branch
2 times, most recently
from
dbefcf5
to
6e7deaa
Compare
Restore batch notification with non-blocking attempts.
Check mask before locking the reference. Can help to not bother non-eligible waiters.
It's not an optimization. It just allows some tricks safely.
Should fit into cache line perfectly. Also makes ptr check more robust.
|
I fixed CPU overusage issue, also performance may improve a little bit. But could be my imagination. |
Compress 16-bit ref counter and two 48+64 bit slot allocators. This allowed to remove some weird unnecessary logic paths. Adjust hashtable size to keep it the same.
Silly MSVC emits unnecessary initialize-on-first-use code guards. Didn't check other compiler. But workaround just works anyway.
Nekotekina
changed the title
Make sure forced notification ignores mask comparison. Also fix masks provided by smaller types to correct ones.
|
Performance improved in "Wet" by an average of 30-50% depending on the arena. Previously, there were drawdowns of up to 13 frames, now the minimum is 24 FPS. You can move the game to the Playable category. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No effect, but sorry if it breaks Accurate DMA. I hope it doesn't.