New atomic fixups #9259
Merged
New atomic fixups #9259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary optimization from cond_alloc(). Optimistic case was absolutely dominating anyway. Although the whole function is a dirty hack. Now scanning through all threads is faster.
Also added missing const noexcept.
Nekotekina
force-pushed
the
fixup
branch
4 times, most recently
from
ad63f11
to
0847089
Compare
Use 128-bit allocator instead of queue. When pool is full (128), threads just terminate as before.
|
TODO: get_cycles() doesn't make sense sometimes. Not sure if caused by thread pool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs in thread pool as well.