New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow emulation to work without firmware #9367
Conversation
Not sure how end-user ready this is, but I gave it a shot with the cube sample and it fails to display anything. The "no firmware installed" error message also still comes up, might wanna reword that and demote it into a warning msgbox. edit: oh, the triangle test works tho :p |
eda33bf
to
2f9e397
Compare
Made cube test work fw-less. |
Self compiled the latest commit due to git being pissy, can confirm the cube sample works now too. I'm still unsure to what extent the fully HLE mode is supposed to work with real games, I tested Armored Core: For Answer out of sheer curiousity, and it fatals right before it could show anything. May be fine for the time being though. In case it's not: RPCS3.log.gz Idk what's up with git on windows now btw, but just like Azure, I had massive troubles cloning the submodules. Took several tries and manual cleanings to get all of them properly pulled. Weird stuff. Latest exe until the CI starts working again: rpcs3.exe.gz |
They need HLE SPURS and a few other HLE libs which are yet to be working properly. |
I'm not sure about letting new users run rpcs3 without firmware at this point, I feel like it'll just cause a lot of "why doesn't my game work" questions. I feel like this should be a debug setting or something, at least until our HLE is significantly improved. Sure, there's a dialog to warn users, but many people just click yes/ok without reading any of it. |
If X game does not boot without firmware, and didnt boot before, what difference does it make for the end user? |
Previously they got a "Boot failed because firmware is missing" dialog box that they could not get past. They'd either stop to read it, or in worst case ask someone about "the weird error" that very clearly states what the issue is. With these changes they'd click ok to dismiss the annoying popup, then get some weird error like black/white screen, access violation or whatever. They get confused and ask about why they're getting a black screen or whatever, which is more annoying for the other guy to figure out. |
Also, adding it as an option would mean that people who intentionally run rpcs3 without firmware (for testing purposes f.ex.) wouldn't have to click ok to dismiss the warning every time they launch something. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if the firmware check was split into another PR, since reviewers differ between the topics.
386f44e
to
213254b
Compare
Btw, I think you didn't really implement MSuih's suggestion. The current state (in pseudo code):
MSuih's suggestion:
|
I prefer that "pure HLE/no fw" mode available all the time reagrdless of any setting, guarding with a simple yes/no question dialoge suffices. |
30a120f
to
8bbd9ba
Compare
* Fix HLE prx path detection. * Fix manual list loading bugs.
Resulted in an unexpected dependancy on firmware files.
0650130
to
9c46758
Compare
Why hardcode sprx list? What if you want to try old firmware versions that lack some of these modules? It seems better to just use what's listed in the folder |
Its OK to select files which do not exist, it doesnt crash or anything like that. Also if you want to switch between different fw versions and use the GUI setting it will forget your picks on files which didnt exist on older versions after switching to newer versions, which is fixed here. |
Do not depend on /dev_flash/sys/external/ contents.
HLE missing SPRX files, if no firmware is installed a pure HLE mode is activated.
More stuff: