Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory viewer: Implement RSX mode #9605

Merged
merged 1 commit into from Feb 1, 2021
Merged

memory viewer: Implement RSX mode #9605

merged 1 commit into from Feb 1, 2021

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jan 14, 2021 •
edited

Enhancements

  • Implement RSX memory manager hook.
  • Set the ground for RSX modes of register editor and instruction editor, do not use shared ptrs directly.
  • Make register editor and instruction editor modeless to allow to copypaste values from thread context etc in the background. (they close automatically after switching thread)

Bugfixes

  • Fixed crash when viewing an image that was out of bounds of SPU LS.

@elad335 elad335 force-pushed the rsx-view branch 6 times, most recently from 8346685 to ebf214e Compare January 15, 2021 05:03
@Nekotekina
Copy link
Member

Maybe it's time to derive rsx::thread from cpu_thread, it doesn't even need to support all functionality

@elad335 elad335 force-pushed the rsx-view branch 2 times, most recently from 4986457 to a03bcd5 Compare February 1, 2021 18:46
@elad335 elad335 changed the title memory viewer: Implement RSX mode (unused) memory viewer: Implement RSX mode Feb 1, 2021
@elad335
Copy link
Contributor Author

elad335 commented Feb 1, 2021

Updated pr to use RSX memory viewer mode.

@elad335 elad335 force-pushed the rsx-view branch 3 times, most recently from ae0dc8f to d43997e Compare February 1, 2021 19:44
Megamouse
Megamouse reviewed Feb 1, 2021
View reviewed changes
rpcs3/rpcs3qt/debugger_frame.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/instruction_editor_dialog.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/instruction_editor_dialog.cpp Outdated Show resolved Hide resolved
@elad335 elad335 force-pushed the rsx-view branch 7 times, most recently from a82ef18 to 23dc830 Compare February 1, 2021 20:59
@elad335
memory viewer: Implement RSX mode
6905cce 
* Set the ground for RSX modes of register editor and insttruction editor, do not use shared ptrs directly.
* Make register editor and instruction editor modeless to allow to copypaste values from thread context etc in the background.
@Nekotekina Nekotekina merged commit 2005c89 into RPCS3:master Feb 1, 2021
@elad335 elad335 deleted the rsx-view branch March 16, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

Assignees
No one assigned
Labels
Debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elad335 @Nekotekina @Megamouse