debugger: Implement F1 helper #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Jan 21, 2021
rpcs3/rpcs3qt/debugger_frame.cpp
Outdated
| { | ||
| case Qt::Key_F1: | ||
| { | ||
| QDialog* diag = new QDialog(this); |
There was a problem hiding this comment.
why do you always call it diag..... this makes zero sense
There was a problem hiding this comment.
Fixed, I fixed it in other places as well.
rpcs3/rpcs3qt/debugger_frame.cpp
Outdated
| return; | ||
| } | ||
| } | ||
|
|
||
| if (!isActiveWindow() || !cpu) |
There was a problem hiding this comment.
there's a reason why we return if this is not the active window...
Megamouse
reviewed
Jan 21, 2021
| @@ -227,7 +227,44 @@ void debugger_frame::keyPressEvent(QKeyEvent* event) | |||
| const auto cpu = this->cpu.lock(); | |||
| int i = m_debugger_list->currentRow(); | |||
|
|
|||
| if (!isActiveWindow() || !cpu) | |||
| if (!isActiveWindow()) | |||
There was a problem hiding this comment.
This should be at the beginning of the function, and the cpu and currentRow stuff after your new switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9101