Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto updater when RPCS3_CONFIG_DIR is set #9750

Merged
merged 1 commit into from Feb 9, 2021
Merged

Fix auto updater when RPCS3_CONFIG_DIR is set #9750

merged 1 commit into from Feb 9, 2021

Conversation

vieiraa
Copy link
Contributor

@vieiraa vieiraa commented Feb 9, 2021

Replace GetEmuDir() with GetExeDir() in handle_rpcs3. If RPCS3_CONFIG_DIR is set, the update will be extracted there, and not in the exe folder.
Not sure on how to test this, though.

@Nekotekina
Copy link
Member

Well, what's the problem to test?

@Megamouse Megamouse added the GUI label Feb 9, 2021
Copy link
Contributor

@RipleyTom RipleyTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, presumably the dev_hdd0 stuff should go in the in GetHddDir() dir rather than config/exe dir but it's not critical(as it only contains samples).

@Nekotekina
Copy link
Member

Sorry that I had to revert it, maybe rpcs3 is just not ready for changing config location on windows.

@vieiraa
Copy link
Contributor Author

vieiraa commented Feb 9, 2021

Sorry for the trouble. I will think of a better solution

@MSuih
Copy link
Member

MSuih commented Feb 9, 2021

It might have something to do with wimdows using \ as file separator, maybe the issue is with GetExeDir. But thats just a guess

@vieiraa
Copy link
Contributor Author

vieiraa commented Feb 9, 2021

Is there a way to test the updater? Can I do a "fake" update to test it?

@Megamouse
Copy link
Contributor

You just need to manually search for updates on local builds and it tries to update to master.
The option is somewhere in the menu bar in the main window.

@RipleyTom
Copy link
Contributor

Yeah the problem is indeed GetEmuDir returns a unix style path with /s and GetExeDir returns a windows style path with \s and the rest of the windows path assume it's unix path. The change is still a good idea though, just need to change the '/' to '\' in code.

Sorry I couldn't test and yes you can test just for an update with "Check for update" under Help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants