PPU LLVM: Reduce PRX/OVL compilation memory usage a little #9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
reviewed
Feb 13, 2021
rpcs3/Loader/ELF.h
Outdated
| @@ -329,6 +324,21 @@ class elf_object | |||
| } | |||
| } | |||
|
|
|||
| elf_object& operator=(elf_error error) | |||
There was a problem hiding this comment.
Sad. Could just make set_error public. This operator indirectly violates the rule of 0/3/5. For instance, the elf object has its own implicit copy/move constructors and operators.
xxx = elf_object{} must be called explicitly if you want to clear it.
There was a problem hiding this comment.
Another tiny public method clear could do it.
Megamouse
reviewed
Feb 13, 2021
Nekotekina
reviewed
Feb 13, 2021
rpcs3/Loader/ELF.h
Outdated
| @@ -190,6 +185,8 @@ class elf_object | |||
|
|
|||
| public: | |||
| elf_object() = default; | |||
| elf_object(const elf_object&) = delete; // Disabled for performance reasons | |||
There was a problem hiding this comment.
What performance reasons? I don't see any. This object should be freely copyable or moveable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements