Add a new config-only option to prevent exclusive full screen mode #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13xforever
force-pushed
the
feature/non_exclusive_fullscreen
branch
3 times, most recently
from
5a267c2
to
44e9688
Compare
elad335
reviewed
Feb 14, 2021
13xforever
force-pushed
the
feature/non_exclusive_fullscreen
branch
from
44e9688
to
32d26e3
Compare
MSuih
reviewed
Feb 14, 2021
13xforever
force-pushed
the
feature/non_exclusive_fullscreen
branch
2 times, most recently
from
f0a9016
to
543abe7
Compare
Megamouse
reviewed
Feb 14, 2021
13xforever
force-pushed
the
feature/non_exclusive_fullscreen
branch
2 times, most recently
from
62123d0
to
67e4183
Compare
this is helpful for people streaming RPCS3, or to prevent disabling HDR mode in Windows
13xforever
force-pushed
the
feature/non_exclusive_fullscreen
branch
from
67e4183
to
84ed5ae
Compare
kd-11
reviewed
Feb 14, 2021
| @@ -586,8 +586,49 @@ namespace vk | |||
| VkSwapchainKHR old_swapchain = m_vk_swapchain; | |||
| vk::physical_device& gpu = const_cast<vk::physical_device&>(dev.gpu()); | |||
|
|
|||
| VkSurfaceCapabilitiesKHR surface_descriptors = {}; | |||
| CHECK_RESULT(vkGetPhysicalDeviceSurfaceCapabilitiesKHR(gpu, m_surface, &surface_descriptors)); | |||
| VkSurfaceCapabilities2KHR pSurfaceCapabilities = {}; | |||
There was a problem hiding this comment.
This method is uncomfortably long now, I'll have to refactor it later. Seems fine otherwise.
kd-11
approved these changes
Feb 14, 2021
|
That feature is for Linux too ? |
|
Please do not necropost. This feature was superseded by more flexible option, and it's a vulkan feature. Whether drivers advertise or support it is another matter. In the future please use discord or support forum to ask questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for people streaming RPCS3, or to prevent disabling HDR mode in Windows.
Fixes #7975
New option is under
Vulkansection of config.yml, it is disabled by default to maintain current behavior.People with multimonitor setup should test if switching to full screen works on different screens as expected.