Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Import Custom Icons #9954

Merged
merged 4 commits into from Mar 13, 2021
Merged

Qt: Import Custom Icons #9954

merged 4 commits into from Mar 13, 2021

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Mar 12, 2021

Implements and closes #9923

Import

image

View

image

Remove

image

Enable/Disable

image

@Megamouse Megamouse added the GUI label Mar 12, 2021
@Megamouse
Copy link
Contributor Author

Keep in mind that the game list refresh will be slower, if you use higher resolution icons.

@Megamouse
Copy link
Contributor Author

Added option to enable and disable all custom icons

@Megamouse
Copy link
Contributor Author

I found some overcomplicated code when I stared at the code.
I think the icon scaling and thus the game list refresh might now be slightly faster.
This also affects the trophy manager and the save data manager.

Please test and see if there are any regressions or hopefully speedups.

@Megamouse Megamouse force-pushed the importicons branch 2 times, most recently from f742d18 to f9ca16e Compare March 13, 2021 02:55
@Megamouse
Copy link
Contributor Author

Removed the last commit. Turns out that the simpler downscaling with QPainter does look worse than what we already had.
What a waste of time.

image

@Megamouse Megamouse merged commit c0d823f into RPCS3:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] GUI option for "Import Custom Icon"
1 participant