GUI: Handle uppercase RAP file extension #9956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice QoL change! Will mean a lot less people asking for help. |
|
|
|
If I'm already working on it, what is the a reason RAP files are installed only for the current user and not for all users? |
|
Why would anyone want that |
Megamouse
reviewed
Mar 13, 2021
elad335
force-pushed
the
rap
branch
2 times, most recently
from
8755f93
to
7ebe32a
Compare
Megamouse
reviewed
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to either drap-and-drop or install uppercase RAP files from menu, detect it as RAP file (instead of trying to execute it as a PS3 executable) and rename extension to be lowercase ".rap" automatically.
This is a quality of life improvement. Especially on Windows which on atleast on my Windows 10 and exFAT does not let me rename files if the only difference with its new filename is its characters' case, probably a broken "optimization" of File Explorer which attempts to detect same name before rename and avoids rename is such case. FYI to workaround this bug of File Explorer you need to rename the file to something different (so characters case would not be the only difference) and only then rename it to the final name.
Handle all PUP files in drag-and-drop, not just PS3UPDAT.PUP. This is useful for when you have multiple PUP files in a folder (e.g. for different fw versions) such as "PS3UPDAT (1).PUP". There is no much sense in blocking other PUP files, even if its a file meant for other uses for other programs because our PUP loader's error checking is superb.
Install RAP files atomically, ensure that its contents won't be corrupt if the source file was valid to begin with.
Detect illegal RAP files, log an error about it as well. Such as if the user attempts to create an empty RAP file.