Skip to content

Commit

Permalink
Normalize star ratings markup. Props helenyhou. fixes #20655
Browse files Browse the repository at this point in the history
git-svn-id: http://core.svn.wordpress.org/trunk@20765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  • Loading branch information
ryan committed May 10, 2012
1 parent a487b6b commit 6f87716
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 21 deletions.
11 changes: 3 additions & 8 deletions wp-admin/css/wp-admin-rtl.dev.css
Expand Up @@ -2274,14 +2274,15 @@ body.login {
float: right;
}

/* plugin-install */
/* Star ratings */
div.star-holder {
background: url('../images/stars-rtl.png?ver=20120506.png') repeat-x bottom right;
}
div.star-holder .star-rating {
background: url('../images/stars-rtl.png?ver=20120506.png') repeat-x top right;
float: right;
}

#plugin-information ul#sidemenu {
left: auto;
right: 0;
Expand Down Expand Up @@ -2426,14 +2427,8 @@ h3.tb {
float: right;
}

.theme-details .theme-rating {
.theme-details .star-holder {
float: left;
background: url('../images/stars-rtl.png?ver=20120307') repeat-x bottom right;
}

.theme-details .theme-rating div {
background: url('../images/stars-rtl.png?ver=20120307') repeat-x top right;
float: right;
}

.feature-filter .feature-group {
Expand Down
13 changes: 2 additions & 11 deletions wp-admin/css/wp-admin.dev.css
Expand Up @@ -5509,18 +5509,9 @@ body.full-overlay-active {
float: left;
}

.theme-details .theme-rating {
.theme-details .star-holder {
margin: 14px 0;
width: 100px;
height: 17px;
float: right;
background: url('../images/stars.png?ver=20120307') repeat-x bottom left;
}

.theme-details .theme-rating div {
background: url('../images/stars.png?ver=20120307') repeat-x top left;
height: 17px;
float: left;
}

.theme-details .theme-description {
Expand Down Expand Up @@ -7129,7 +7120,7 @@ body.menu-max-depth-11 { min-width: 1280px !important; }
display: block;
}

/* plugin-install */
/* Star ratings */
div.star-holder {
position: relative;
height: 17px;
Expand Down
4 changes: 2 additions & 2 deletions wp-admin/includes/class-wp-theme-install-list-table.php
Expand Up @@ -338,8 +338,8 @@ function install_theme_info( $theme ) {
<img class="theme-screenshot" src="<?php echo esc_url( $theme->screenshot_url ); ?>" />
<?php endif; ?>
<div class="theme-details">
<div class="theme-rating" title="<?php echo esc_attr( $num_ratings ); ?>">
<div style="width:<?php echo esc_attr( intval( $theme->rating ) . 'px' ); ?>;"></div>
<div class="star-holder" title="<?php echo esc_attr( $num_ratings ); ?>">
<div class="star-rating" style="width:<?php echo esc_attr( intval( $theme->rating ) . 'px' ); ?>;"></div>
</div>
<div class="theme-version">
<strong><?php _e('Version:') ?> </strong>
Expand Down

0 comments on commit 6f87716

Please sign in to comment.