perf: avoid concat in sha1 checksum impl
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decrypting large files, the `data` used in the `sym::SymmetricKeyAlgorithm::decrypt_protected` message would be copied via the `concat` used when taking the checksum. This change updates the function to avoid the copy, by iterating over the relevant parts of the checksum as immutable references.
nightly builds are having trouble on `cargo check` - the command warns against the top level `pub use self::composed::key::*;` entry in `lib.rs`. this change disables that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decrypting large files, the
dataused in thesym::SymmetricKeyAlgorithm::decrypt_protectedmethod would be copied via theconcatused when taking the checksum.This change updates the function to avoid the copy, by iterating over the relevant parts of the checksum as immutable references. This should be "transparent" to the overall api of the lib so I thought it might make a nice change.
Use Case
I am using
gpgto create large filesystem updates (basically,.ext4.gpg) that can be several hundred MB in size, destined for embedded machines with only several hundred MB of RAM. On those machines, I am using this library in my application to decrypt the updates and apply them. Currently, I am running out of memory during the process.I did some testing to verify that
concatdoes indeed result in allocations here: gist.github.com/dadleyy/a7f8f01, using theInstrumentsapplication on my macOS machine.