fix: do not allow decryption with "Plaintext" algorithm #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/no-plaintext-decryption
branch
from
e07d51f
to
3870b5d
Compare
|
I wish we had a test for this |
link2xt
force-pushed
the
link2xt/no-plaintext-decryption
branch
5 times, most recently
from
9fec1b8
to
175b277
Compare
|
@dignifiedquire I added one test, but testing the same for symmetrically decrypted key, asymmetrically decrypted key, derived key etc. is too difficult, so this only tests one code path. |
|
thanks : |
According to <https://datatracker.ietf.org/doc/html/rfc4880#section-13.4> "plaintext" MUST NOT be used to encrypt data packets. We check that "plaintext" algorithm is not used to decrypt messages and is not used to decrypt session keys when the key is derived using S2K.
link2xt
force-pushed
the
link2xt/no-plaintext-decryption
branch
from
175b277
to
92b2011
Compare
dignifiedquire
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://datatracker.ietf.org/doc/html/rfc4880#section-13.4 "plaintext" MUST NOT be used to encrypt data packets.
We check that "plaintext" algorithm is not used
to decrypt messages and is not used to decrypt session keys
when the key is derived using S2K.