Skip to content

Commit

Permalink
Default options to empty {}
Browse files Browse the repository at this point in the history
Summary:
API Key is not longer required.

Test Plan:
http://www.naitik.dev575.snc1.facebook.com/fbconnect/tests/index.html?initialize&api

DiffCamp Revision: 113927
Reviewed By: alpjor
CC: platform-diffs@lists, lshepard, brent, mattwkelly, alpjor, selekman
Revert Plan:
OK
  • Loading branch information
daaku committed May 14, 2010
1 parent 3d1a1e9 commit 498d7af
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
2 changes: 1 addition & 1 deletion src/core/init.js
Expand Up @@ -125,7 +125,7 @@ FB.provide('', {
init: function(options) {
// only need to list values here that do not already have a falsy default.
// this is why cookie/session/status are not listed here.
FB.copy(options, {
options = FB.copy(options || {}, {
logging: true
});

Expand Down
16 changes: 0 additions & 16 deletions tests/js/debug_logs.js
Expand Up @@ -79,19 +79,3 @@ test(
FB._session = oldSession;
}
);

test(
'FB.init api key',

function() {
expect(1);

var logCb = function(msg) {
ok(msg == 'FB.init() called without an apiKey.',
'got the expected log message that the apiKey was not found.');
};
FB.Event.subscribe('fb.log', logCb);
FB.init();
FB.Event.unsubscribe('fb.log', logCb);
}
);

0 comments on commit 498d7af

Please sign in to comment.