Added support to force careful disarming. #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaml setting `lockpick_force_disarm_careful: true`, but should default to false.
rpherbig
reviewed
Aug 20, 2018
pick.lic
Outdated
| @@ -391,10 +391,11 @@ class LockPicker | |||
| when 'Roundtime', *@disarm_careful | |||
| disarm_speed?(box, 'careful') | |||
| when *@disarm_quick | |||
| disarm_speed?(box, 'quick') | |||
| disarm_speed?(box, 'careful') if @settings.lockpick_force_disarm_careful | |||
| disarm_speed?(box, 'quick') if !@settings.lockpick_force_disarm_careful | |||
There was a problem hiding this comment.
💡 Consider using unless for the if !... cases
rpherbig
reviewed
Aug 20, 2018
pick.lic
Outdated
| when *@disarm_normal | ||
| disarm_speed?(box, 'normal') | ||
| when *@disarm_identify_failed |
There was a problem hiding this comment.
❓ Was this when supposed to be removed?
|
Fixed, and no that when was not supposed to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaml setting
lockpick_force_disarm_careful: true, but should default to false.Will add it to base.yaml and PR that too. Too inexperienced with github to do them at the same time.