Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it so you're forced to wait until 4pm on Sunday to signup #104

Merged
merged 3 commits into from
Jan 26, 2020

Conversation

lramos15
Copy link
Member

Changes the effective turnover time to 4pm Sunday. I also cleaned up an undefined offset error and added the reasons you may be inelegible for a spot.

.crews.php Outdated
$yesterday = mktime(0, 0, 0, date('m'), date('d'), date('y')) - 86400;
$signupdate = mktime(0, 0, 0, $m, $d, $y);
$fourpmsunday = mktime(16, 0, 0, date('m'), date('d'), date('y'));
if (date("D") == "Sun" && time() < $fourpmsunday && $yesterday < $signupdate) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic appears logical.

Copy link
Contributor

@jcub jcub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on logic check, I am approving. Reasons for not being able to ride could be tweaked a bit.

@ddbruce
Copy link
Member

ddbruce commented Jan 26, 2020

Do we want to put this in a dev branch for testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants