Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to the docker-compose file #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tweaks to the docker-compose file #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .local.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
SPRING83_FQDN=spring83.example.com
SPRING83_CONTACT_ADDR=spring83@example.com
14 changes: 4 additions & 10 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@ services:
dockerfile: Dockerfile
target: serve
network_mode: "host"
environment:
- SPRING83_FQDN=${SPRING83_FQDN}
- SPRING83_CONTACT_ADDR=${SPRING83_CONTACT_ADDR}
volumes: &default-logs-bind
- type: bind
source: ${SPRING83_CONTENT_DIR_HOST:?"Must define SPRING83_CONTENT_DIR_HOST as the absolute path to logs on the host."}
target: /content
env_file:
- .local.env
volumes:
- ./content:/content
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the .env file thing a lot (honestly can't recall if I've ever used that!), but the removal of SPRING83_CONTENT_DIR_HOST won't work because ./content isn't where I keep them on my system. I'd prefer to keep that as an env for now (just because I'm lazy and it's already in my .bashrc). Overall though I don't disagree that this isn't ideal: there has to be a better way right?


volumes:
content:
external: true