Skip to content
This repository has been archived by the owner on Feb 5, 2019. It is now read-only.

Composer.lock has no effect on libraries and shouldn't be in source control #17

Merged
merged 2 commits into from Feb 7, 2018
Merged

Composer.lock has no effect on libraries and shouldn't be in source control #17

merged 2 commits into from Feb 7, 2018

Conversation

luispabon
Copy link
Contributor

No description provided.

@rpkamp
Copy link
Owner

rpkamp commented Feb 7, 2018

composer.lock is marked as export-ignore in .gitattributes, so it will not be distributed anyway.

However I agree it doesn't really make much sense having a composer.lock in here.

Could you please add it to .gitignore as well, so people won't start adding it again later?

@luispabon
Copy link
Contributor Author

done 👍

@rpkamp
Copy link
Owner

rpkamp commented Feb 7, 2018

Awesome, thank you!

@rpkamp rpkamp merged commit da0175d into rpkamp:master Feb 7, 2018
@luispabon luispabon deleted the remove-composer-lock branch February 7, 2018 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants