This repository has been archived by the owner on Feb 15, 2020. It is now read-only.
Fix string value deserialization, other improvements #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure dump/load kwargs are provided to the init method instead of setting them on the instance after initialization.
Readds indentation and adds spaces after separators
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
===========================================
+ Coverage 80.95% 96.03% +15.08%
===========================================
Files 2 3 +1
Lines 84 101 +17
Branches 14 14
===========================================
+ Hits 68 97 +29
+ Misses 9 1 -8
+ Partials 7 3 -4
Continue to review full report at Codecov.
|
Default help_text values are non-standard, and it should probably be removed. However, moving this to the form field allows subclasses to override or otherwise disable this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a number of small improvements, but most importantly fixes #11 and fixes #9.