feat: expose upload total size for progress event #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @rickythink |
yoavniran
reviewed
Aug 27, 2023
yoavniran
reviewed
Aug 27, 2023
yoavniran
reviewed
Aug 27, 2023
yoavniran
reviewed
Aug 27, 2023
|
Hey @rickythink |
Co-authored-by: Yoav Niran <yoavniran@users.noreply.github.com>
|
thanks @rickythink ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I hope you are doing well! I wanted to submit a pull request for exposing an additional 'total upload file size' parameter in the onProgress event. I believe this change will improve the project by making it easier for developers to display the total upload size of the file, which is diffrent with the local file size as described on ProgressEvent/total
I have tested this change locally and updated the onProgress handler to use this new parameter. Please let me know if you would like me to add any additional tests or documentation.
If you feel this pull request could be improved in any way, please let me know so I can update it. I'm happy to make any edits to get this merged.
Thank you for your time and consideration. I look forward to hearing your feedback!
Let me know if you would like me to modify the language or contents of this pull request template further. I'm happy to help craft effective communication for your needs.