WIP: utilize binrw serialization/deserialization for Lead #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxin
force-pushed
the
wip-binrw-for-Lead
branch
from
70380b5
to
c2ecde7
Compare
|
To be completely honest I find the macros less straightforwards to read than the current code, which is pretty clean and not particularly complex. |
dralley
reviewed
Jun 9, 2024
| name_arr[..name_size].clone_from_slice(&name.as_bytes()[..name_size]); | ||
| name_arr | ||
| })] | ||
| name: String, |
There was a problem hiding this comment.
I would prefer to keep the data in the lead structure identical to what was on disk, rather than storing it as a potentially modified string
What does it look like without that?
Sure, understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. Recently, I've been playing with a great binary serialization and deserialization library and thought it would be cool to use it for the RPM project. What are the thoughts of the community about it?
I made a simple demonstration for the
Leadstruct, but I'm still struggling when it comes to more complex data likeIndexData(where the content is split between The Index Entry and the actual data). I'm still working on that (jam1garner/binrw#267).