Don't add /bin/sh as a dependency #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
approved these changes
Nov 11, 2022
|
@tofay could you rebase the PR so this can be landed :) thank you! |
|
If I have to guess, it may have been something to do with "scriptlets". So perhaps something else related to that may be broken? However I agree that it doesn't make sense to declare unconditionally. LGTM |
dralley
approved these changes
Nov 21, 2022
|
@tofay gentle ping |
to enable the production of RPMs which don't require /bin/sh Signed-off-by: Tom Fay <tomfay@microsoft.com>
tofay
force-pushed
the
no-bin-sh-requires
branch
from
39afd49
to
2d2486b
Compare
drahnr
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates rpm-rs to not universally add /bin/sh as a required dependency.
I want to use rpm-rs (via cargo-generate-rpms) to create RPMs that don't depend on /bin/sh , as I want to then install the RPMs I'm producing into a container, and I don't want a shell and its dependencies installed in the container.
I can't find any rationale for the existing behaviour - it was added in ecbcdab#diff-43fb48f0415ccc8ae772c068cc4bc8717f04a0e93a4113396ce0b48deddd9af6.