Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R(ABI) dependency generation #1

Merged
merged 1 commit into from May 14, 2020

Conversation

spotrh
Copy link
Contributor

@spotrh spotrh commented May 12, 2020

Equivalent to how Python handles ABI dependency, create and apply a R(ABI) dependency using the R major and minor version (but not the patch version). The Provides: R(ABI) will be set in R-core. This should prevent mismatched installations.

@Conan-Kudo
Copy link
Member

@spotrh Could you fix your commit message? The title of this PR makes sense as the title of the Git commit and makes it much more readable. 😄

@spotrh
Copy link
Contributor Author

spotrh commented May 13, 2020

Done!

@Conan-Kudo
Copy link
Member

Conan-Kudo commented May 13, 2020

@spotrh I meant you should just add the title to the commit message, like so:

Add R(ABI) dependency generation

Equivalent to how Python handles ABI dependency,  create and apply a
R(ABI) dependency using the R major and minor version (but not the
patch version). The Provides: R(ABI) will be set in R-core.
This should prevent mismatched installations.

Equivalent to how Python handles ABI dependency, create and apply a
R(ABI) dependency using the R major and minor version (but not the
patch version). The Provides: R(ABI) will be set in R-core.
This should prevent mismatched installations.
@spotrh
Copy link
Contributor Author

spotrh commented May 13, 2020

If you'd like it in Klingon, let me know. ;)

Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! 💯

@spotrh
Copy link
Contributor Author

spotrh commented May 13, 2020

If a release with this change could please make its way to rawhide, I can start working on the R 4.0.0 mass rebuild. :)

@QuLogic
Copy link
Collaborator

QuLogic commented May 14, 2020

I'm okay with this, if you want to be doing rebuilds of everything. I left something like this out to avoid it as it didn't always seem necessary.

I don't think this can come to Rawhide just yet as it'd break every other build; maybe you want to build in a side tag?

@QuLogic QuLogic merged commit 5f25268 into rpm-software-management:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants