History tests #248
Merged
History tests #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,3 +263,21 @@ def then_the_section(context, section, pkgs): | |||
| return | |||
| except StopIteration: | |||
| raise AssertionError('section {} has not been found'.format(section)) | |||
|
|
|||
There was a problem hiding this comment.
please, nothing in test_behave. it's deprecated
There was a problem hiding this comment.
Sorry I didn't know that. Will fix it...
There was a problem hiding this comment.
should be fine for now... I will probably add some more this week.
dnf-bot
reviewed
Feb 14, 2017
| @@ -0,0 +1,21 @@ | |||
| from behave import then | |||
| from behave import when | |||
There was a problem hiding this comment.
[flake8]
- [F401] 'when' imported but unused
dnf-bot
reviewed
Feb 14, 2017
| @@ -0,0 +1,21 @@ | |||
| from behave import then | |||
| from behave import when | |||
| from behave import given | |||
There was a problem hiding this comment.
[flake8]
- [F401] 'given' imported but unused
edcuba
force-pushed
the
master
branch
2 times, most recently
from
980ad00
to
d4faec9
Compare
| Feature: DNF/Behave test Transaction history - base | ||
|
|
||
| Scenario: Simple transaction | ||
| Given I use the repository "test-1" |
There was a problem hiding this comment.
This step is deprecated
|
|
||
| Scenario: Simple transaction | ||
| Given I use the repository "test-1" | ||
| When I execute "dnf" command "install -y TestA" with "success" |
There was a problem hiding this comment.
This step is deprecated
There was a problem hiding this comment.
Are there any alternatives for these two? Or should I write new ones?
There was a problem hiding this comment.
there is, check obsoletes-reason for example
edcuba
force-pushed
the
master
branch
4 times, most recently
from
4941cfd
to
9fb473c
Compare
|
Should be fine now |
| Scenario: Update packages | ||
| When I save rpmdb | ||
| And I successfully run "dnf install -y TestA TestB TestD" | ||
| When I save rpmdb |
There was a problem hiding this comment.
you should first check if all those packages have been installed correctly
| | removed | TestA, TestB | | ||
| And history should contain "history undo last -y" with action "Erase" and "2" packages | ||
|
|
||
| Scenario: Undo transaction last 2 |
There was a problem hiding this comment.
is Undo last transaction 2 better? 😄
edcuba
force-pushed
the
master
branch
3 times, most recently
from
5c1cab3
to
4803390
Compare
ignatenkobrain
force-pushed
the
master
branch
from
3b7cfbf
to
e8dc2b9
Compare
|
History tests should be complete now. Edit: added |
|
fixed indentation |
|
Then history info is broken in upstream I have the same output in rawhide docker image Like I said, rpm-software-management/dnf#756 should fix that issue |
|
@edynox Still one of the step is failing even with your patch: |
|
@edynox Please can you fix that it will work with upstream version? Then I can merge it. Thanks a lot. Please if there is any problem, just let me know. |
|
@j-mracek Then upstream and SWDB output should be the same and I will rewrite this test so transaction merging will be tested properly (and passed by both upstream an SWDB) It is quite lot of work with proper transaction merging so I will need a few days... |
|
rpm-software-management/libdnf@509f859 introduces transaction merging in SWDB, I will write some tests on it here. YumMergedHistoryTransaction and YumHistoryTransaction were dropped from dnf. |
|
@j-mracek Merged transactions should be tested properly now. Its working on upstream for me. |
|
@j-mracek Can you finish the review, please? |
|
@edynox I am sorry but I got: Second time that I repeated it, it passed (same container), and first test output is not reachable. The reason has be found first. |
|
Reinstall should fail when source repository is disabled.
When package is being replaced, new package must keep reason of obsoleted package.
Test whether transactions are merged properly in history info output.
|
This is kinda interesting. Transaction merging in DNF is not working correctly (works fine with SWDB). I tried it several times and found these problems: Caused by: Line is missing and
caused by while it should be |
edcuba
pushed a commit
to edcuba/dnf
that referenced
this pull request
Oct 9, 2017
Make Transaction method `__lt__` work in an expected way.
True if t1.tid < t2.tid, false when t1.tid > t2.tid.
This fixes the behavior of sort method (lowest/oldest first without
using reverse flag).
Fixes random behavior in CI tests:
rpm-software-management/ci-dnf-stack#248
edcuba
pushed a commit
to edcuba/dnf
that referenced
this pull request
Oct 9, 2017
Make Transaction method `__lt__` work in an expected way.
True if t1.tid < t2.tid, false when t1.tid > t2.tid.
This fixes the behavior of sort method (lowest/oldest first without
using reverse flag).
Fixes random behavior in CI tests:
rpm-software-management/ci-dnf-stack#248
rh-atomic-bot
pushed a commit
to rpm-software-management/dnf
that referenced
this pull request
Oct 10, 2017
Make Transaction method `__lt__` work in an expected way.
True if t1.tid < t2.tid, false when t1.tid > t2.tid.
This fixes the behavior of sort method (lowest/oldest first without
using reverse flag).
Fixes random behavior in CI tests:
rpm-software-management/ci-dnf-stack#248
Closes: #947
Approved by: <try>
j-mracek
pushed a commit
to rpm-software-management/dnf
that referenced
this pull request
Oct 10, 2017
Make Transaction method `__lt__` work in an expected way.
True if t1.tid < t2.tid, false when t1.tid > t2.tid.
This fixes the behavior of sort method (lowest/oldest first without
using reverse flag).
Fixes random behavior in CI tests:
rpm-software-management/ci-dnf-stack#248
|
It should work now |
|
@edynox Thanks, I will run tests several time just to ensure that it is fine. |
|
Thanks, no problem discovered. |
pkratoch
pushed a commit
that referenced
this pull request
Nov 9, 2021
It didn't provide any information why there is any download. https://bugzilla.redhat.com/show_bug.cgi?id=1550006 Closes: #248 Approved by: m-blaha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests for dnf
history undoandredo