Tests for dnf debug-dump / dnf-debug-restore #854
Conversation
The functionality will also be used for file content matching.
This is done the same way as stdout / stderr matching we already have.
| kernel-0:4.19.1-fc29.x86_64 | ||
| kernel-0:4.20.1-fc29.src | ||
| kernel-0:4.20.1-fc29.x86_64 | ||
| test-install-0:1-fc29.src |
There was a problem hiding this comment.
This is the only place where the test-install package is used and since there is a lot of other packages listed here I think we don't really need it.
There was a problem hiding this comment.
Right. It is a left-over of previous version.
| kernel-0:4\.19\.1-fc29\.x86_64 | ||
| kernel-0:4\.20\.1-fc29\.x86_64 | ||
| %%%%REPOS | ||
| %debug-plugin - file:///home/mblaha/work/debug-restore-bz1844533/ci-dnf-stack/dnf-behave-tests/fixtures/repos/debug-plugin |
There was a problem hiding this comment.
I believe this is your local path and it doesn't match in general. We could hard code the path from our container %debug-plugin - file:///opt/behave/fixtures/repos/debug-plugin, but I think we should use another regex here, since the tests can be run in different setups as well.
| test-replace-0:3-fc29.src | ||
| test-replace-0:3-fc29.x86_64 | ||
| %%%%RPMDB VERSIONS | ||
| all: 2:9a5b819daf813e63ecfd470f07bcacb534b506d5 |
There was a problem hiding this comment.
This hash doesn't work when I tried to run it, I don't think we can rely on it being always the same, there is too many moving parts.
There was a problem hiding this comment.
Yes, I was kind of afraid of this. I'll replace the particular hash with regexp.
| kernel-0:4\.19\.1-fc29\.x86_64 | ||
| kernel-0:4\.20\.1-fc29\.x86_64 | ||
| %%%%RPMDB VERSIONS | ||
| all: 2:9a5b819daf813e63ecfd470f07bcacb534b506d5 |
m-blaha
force-pushed
the
mblaha/debug-restore
branch
from
6ca5ce3
to
cf38cbd
Compare
|
Hello @m-blaha! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Alesi, thanks for the review. The issues should be fixed now. |
|
The tests pass now, merging. |
requires: rpm-software-management/dnf-plugins-core#402