Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unicode strings everywhere #17

Closed
jsilhan opened this issue Sep 22, 2015 · 0 comments
Closed

use unicode strings everywhere #17

jsilhan opened this issue Sep 22, 2015 · 0 comments

Comments

@jsilhan
Copy link

jsilhan commented Sep 22, 2015

At the beginning of the plugin should be from __future__ import unicode_literals. This will break the other things though and needs to be fixed on more places.
see https://bugzilla.redhat.com/show_bug.cgi?id=1262082 which failed due to non unicoded characters in system-upgrade command.
We have fixed this in DNF (rpm-software-management/dnf@9e8638d) but the common practice is to use Unicode everywhere and convert bytestring to Unicode as soon as possible.
wgwoods added a commit that referenced this issue Sep 22, 2015
@wgwoods
plugin: use unicode_literals
2fd6e94 
Do like the rest of DNF does: 'from __future__ import unicode_literals'.

This makes all literal strings unicode objects in Python 2.x, which is a
little strange but that's what the rest of DNF expects.

Plugins that fail to do so can cause problems in DNF; see rhbz#1262082.

This should resolve #17.

(cherry picked from commit 58a623c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsilhan