fix issues with translations in python2 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgwoods
added a commit
that referenced
this pull request
Nov 17, 2015
PR #38 fixed both manifestations of our py2 unicode problems, if you have dnf-1.1.4. Unfortunately, Fedora 21 and Fedora 22 don't have that, so we need to backport its `dnf.i18n.translate()` function so we can do translations without crashing all over the place. This re-fixes rhbz#1278031, #32, and #34 (We reverted the original fix in commit 3fbcb9b so we could do this correctly here.) Closes #38, closes #32 (again), closes #34 (again). Resolves: rhbz#1277895 Resolves: rhbz#1278031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.