[reposync] Apply only modular excludes (RhBug:1750273) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I wrote some tests for this patch and assigned you for review: rpm-software-management/ci-dnf-stack#696 |
|
Now I noticed the commit message is a bit misleading, because you are applying only non-modular excludes (or rather ignoring only modular excludes). Can you perhaps replace "Apply" with "Ignore"? |
This is a regression, reposync always used to apply excludes and includes. It only needs to ignore modular dependencies to be able to synchronize non-enabled streams. https://bugzilla.redhat.com/show_bug.cgi?id=1750273
m-blaha
force-pushed
the
reposync_excludes
branch
from
9b6a2c6
to
a19225f
Compare
|
Thanks, good catch. Fixed. |
|
📌 Commit a19225f has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 21, 2019
This is a regression, reposync always used to apply excludes and includes. It only needs to ignore modular dependencies to be able to synchronize non-enabled streams. https://bugzilla.redhat.com/show_bug.cgi?id=1750273 Closes: #368 Approved by: pkratoch
|
💥 Test timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression, reposync always used to apply excludes and
includes. It only needs to ignore modular dependencies to be able to
synchronize non-enabled streams.
https://bugzilla.redhat.com/show_bug.cgi?id=1750273