needs_restarting: Fix boot time derivation for systems without RTC #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Todd, thanks for working on this. I was testing that in the container and it seems working fine! I don't see any issue regarding your solution now and tests are passing, so I am for the merge. Just to sum it up. We have two sources for the boot time which is now used in the implementation:
Please could you add comments/docstrings with the explanation of this change into the code? Also please mention the bugzilla ticket inside the commit description (look f.e. here) + choose better title e.g. |
utoddl
changed the title
utoddl
force-pushed
the
rewrite_get_boot_time
branch
from
4896b74
to
b8132e1
Compare
dcantrell
added a commit
to dcantrell/dnf-plugins-core
that referenced
this pull request
Mar 27, 2023
This problem was reported on RHEL-8 for ppc64le. I confirmed the reproducer does work. It also affects RHEL-9. Fortunately, this problem was reported and addressed in Fedora. I confirmed the fix works for at least RHEL-8 on ppc64le. The Fedora issue was reported here, along with the proposed fix: rpm-software-management#468 Signed-off-by: David Cantrell <dcantrell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of the idea from Fedora bugzilla Comment #12. See discussion also #466 (comment)