Skip to content

Commit

Permalink
Ensure that correct python version is used for build
Browse files Browse the repository at this point in the history
PYTHON_DESIRED can be either "2", "3" or a path to interpreter
  • Loading branch information
m-blaha authored and j-mracek committed Jul 23, 2018
1 parent d59f357 commit 679f88f
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 20 deletions.
24 changes: 12 additions & 12 deletions CMakeLists.txt
@@ -1,20 +1,20 @@
PROJECT (dnf-plugins-extras NONE)
CMAKE_MINIMUM_REQUIRED (VERSION 2.4)

if (NOT PYTHON_DESIRED)
set (PYTHON_DESIRED "2")
endif()

if (${PYTHON_DESIRED} STREQUAL "2")
FIND_PACKAGE (PythonInterp REQUIRED)
else()
SET(Python_ADDITIONAL_VERSIONS 3.3)
FIND_PACKAGE(PythonLibs 3.0)
FIND_PACKAGE(PythonInterp 3.0 REQUIRED)
endif()
IF (NOT PYTHON_DESIRED)
FIND_PACKAGE (PythonInterp REQUIRED)
ELSEIF (${PYTHON_DESIRED} STREQUAL "2")
FIND_PACKAGE (PythonInterp 2 EXACT REQUIRED)
ELSEIF (${PYTHON_DESIRED} STREQUAL "3")
FIND_PACKAGE (PythonInterp 3 EXACT REQUIRED)
ELSEIF (EXISTS ${PYTHON_DESIRED})
SET (PYTHON_EXECUTABLE ${PYTHON_DESIRED})
FIND_PACKAGE (PythonInterp REQUIRED)
ELSE ()
MESSAGE (FATAL_ERROR "Invalid PYTHON_DESIRED value: " ${PYTHON_DESIRED})
ENDIF()

EXECUTE_PROCESS(COMMAND ${PYTHON_EXECUTABLE} -c "from sys import stdout; from distutils import sysconfig; stdout.write(sysconfig.get_python_lib())" OUTPUT_VARIABLE PYTHON_INSTALL_DIR)
EXECUTE_PROCESS(COMMAND ${PYTHON_EXECUTABLE} -c "import sys; sys.stdout.write('%s.%s' % (sys.version_info.major, sys.version_info.minor))" OUTPUT_VARIABLE PYTHON_MAJOR_DOT_MINOR_VERSION)
MESSAGE(STATUS "Python install dir is ${PYTHON_INSTALL_DIR}")

SET (SYSCONFDIR /etc)
Expand Down
4 changes: 2 additions & 2 deletions dnf-plugins-extras.spec
Expand Up @@ -276,13 +276,13 @@ mkdir python3

%build
pushd python2
%cmake ..
%cmake .. -DPYTHON_DESIRED:FILEPATH=%{__python2}
%make_build
make doc-man
popd
%if %{with python3}
pushd python3
%cmake -DPYTHON_DESIRED:str=3 ..
%cmake .. -DPYTHON_DESIRED:FILEPATH=%{__python3}
%make_build
make doc-man
popd
Expand Down
8 changes: 4 additions & 4 deletions doc/CMakeLists.txt
Expand Up @@ -16,8 +16,8 @@ INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.kickstart.8
${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.system-upgrade.8
${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.tracer.8
DESTINATION share/man/man8)
if (${PYTHON_DESIRED} STREQUAL "3")
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.rpmconf.8
${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.torproxy.8
DESTINATION share/man/man8)
if (${PYTHON_VERSION_MAJOR} STREQUAL "3")
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.rpmconf.8
${CMAKE_CURRENT_BINARY_DIR}/dnf.plugin.torproxy.8
DESTINATION share/man/man8)
endif()
2 changes: 1 addition & 1 deletion etc/dnf/plugins/CMakeLists.txt
@@ -1,4 +1,4 @@
if (${PYTHON_DESIRED} STREQUAL "3")
if (${PYTHON_VERSION_MAJOR} STREQUAL "3")
INSTALL (FILES torproxy.conf DESTINATION ${SYSCONFDIR}/dnf/plugins)
INSTALL (FILES rpmconf.conf DESTINATION ${SYSCONFDIR}/dnf/plugins)
endif()
2 changes: 1 addition & 1 deletion plugins/CMakeLists.txt
@@ -1,4 +1,4 @@
if (${PYTHON_DESIRED} STREQUAL "3")
if (${PYTHON_VERSION_MAJOR} STREQUAL "3")
INSTALL (FILES rpm_conf.py DESTINATION ${PYTHON_INSTALL_DIR}/dnf-plugins)
INSTALL (FILES torproxy.py DESTINATION ${PYTHON_INSTALL_DIR}/dnf-plugins)
endif()
Expand Down

0 comments on commit 679f88f

Please sign in to comment.