[system-upgrade] Fix issues with corrupt/missing statefile (RhBug:1649745) #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the statefile doesn't exist yet, and system-upgrade upgrade is being run, it fails with "ValueError: invalid null reference in method 'new_VectorString'". This fixes the issue.
|
@kratochvilova I think DNF should log a warning in case of corrupted statefile. Especially in the "reboot" or "upgrade" phase. |
…9745) https://bugzilla.redhat.com/show_bug.cgi?id=1649745 If the statefile is corrupted, it is treated similarly as if it doesn't exist. Note about the ValueError: JSONDecodeError is a subclass of ValueError in python3, and in python2 there is only ValueError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1649745