Fix accessing exception messages #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good. Please can you enhance commit message? Can you add why the work is so important, like catch of error was changed, but error handling was not adjusted to new libdnf error type. Or traceback, bug or something else could help. |
https://bugzilla.redhat.com/show_bug.cgi?id=1634676 Change the error handling, as the type of catched errors was changed.
pkratoch
force-pushed
the
exception-msgs
branch
from
7e289c2
to
3f3af76
Compare
|
Right, thank you. Now I can even add link to a bug, that didn't exist previously. |
|
Thanks for contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.