[doc] Change description of skip_if_unavailable option #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: rpm-software-management/libdnf#701 |
|
I think you wanted to use "formerly" instead of "formally"? Different meaning 😄 Also, maybe "... not only a repo option but also a main config option"? The end of that sentence looks like it's somehow mixed up. |
|
I hope that the commit message was improved. |
skip_if_unavailable option is now not only a repo option but also option of the main config. The commit provides a enhanced description. Additionally there is a change in default. Formerly it was skip_if_unavailable=true, but it was changed to False to provide a better security to users. The commit also change the description according to new default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_if_unavailable option is now not only repo option but also option
an main config. option. The commit provides a description.
Additionally there is a change in default. Formally it was
skip_if_unavailable=true, but it was changed to False to provide a
better security to users. The commit also change the description
according to new default.